[PATCH] staging: rtl8192e: remove unnecessary break
Dan Carpenter
dan.carpenter at oracle.com
Tue Mar 2 16:24:18 UTC 2021
On Tue, Mar 02, 2021 at 11:29:03PM +0800, Perrin Smith wrote:
> From: Perrin Smith <perrinjamessmith at gmail.com>
>
> removed unnecessary break at end of while loop
>
> Signed-off-by: Perrin Smith <perrinjamessmith at gmail.com>
> ---
> drivers/staging/rtl8192e/rtllib_rx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
> index b8ab34250e6a..2de6330b7737 100644
> --- a/drivers/staging/rtl8192e/rtllib_rx.c
> +++ b/drivers/staging/rtl8192e/rtllib_rx.c
> @@ -460,8 +460,6 @@ static bool AddReorderEntry(struct rx_ts_record *pTS,
> ((struct rx_reorder_entry *)list_entry(pList->next,
> struct rx_reorder_entry, List))->SeqNum))
> return false;
> - else
> - break;
No, this break is necessary. The patch introduces a bug. You need to
be careful following checkpatch's advice because it's just a simple
Perl script.
> }
regards,
dan carpenter
More information about the devel
mailing list