[PATCH 0/3] staging: rtl8723bs: Replace sprintf with scnprintf

Candy Febriyanto cfebriyanto at gmail.com
Mon Mar 1 14:02:57 UTC 2021


On Mon, Mar 01, 2021 at 02:45:00PM +0100, Hans de Goede wrote:
> Hi,
> 
> On 3/1/21 2:12 PM, Candy Febriyanto wrote:
> > This patchset replaces most calls to sprintf with scnprintf, thereby
> > preventing potential buffer overflows. The rest I left alone because
> > they write to a buffer passed by a caller that doesn't pass its size
> > alongside it.
> > 
> > Candy Febriyanto (3):
> >   staging: rtl8723bs: core: Replace sprintf with scnprintf
> >   staging: rtl8723bs: hal: Replace sprintf with scnprintf
> >   staging: rtl8723bs: os_dep: Replace sprintf with scnprintf
> > 
> >  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c |  3 +-
> >  drivers/staging/rtl8723bs/core/rtw_pwrctrl.c  |  4 +-
> >  drivers/staging/rtl8723bs/hal/hal_com.c       | 45 ++++++++++---------
> >  .../staging/rtl8723bs/os_dep/ioctl_linux.c    | 20 +++++----
> >  drivers/staging/rtl8723bs/os_dep/mlme_linux.c |  6 +--
> >  5 files changed, 41 insertions(+), 37 deletions(-)
> 
> Thanks, the entire series looks good to me, for the series:
> 
> Reviewed-by: Hans de Goede <hdegoede at redhat.com>
> 
> Regards,
> 
> Hans
> 

Thank you Hans.


More information about the devel mailing list