Reply: Re: [PATCH 3/3] drm/loongson: Add interrupt driver for LS7A

[李晨阳]

> -----Original Messages-----
> From: "Dan Carpenter" <dan.carpenter at oracle.com>
> Sent Time: 2021-07-06 17:05:01 (Tuesday)
> To: lichenyang <lichenyang at loongson.cn>
> Cc: devel at linuxdriverproject.org
> Subject: Re: [PATCH 3/3] drm/loongson: Add interrupt driver for LS7A
> 
> On Tue, Jul 06, 2021 at 02:36:31PM +0800, lichenyang wrote:
> >  int loongson_crtc_init(struct loongson_device *ldev, int index)
> > diff --git a/drivers/gpu/drm/loongson/loongson_drv.c b/drivers/gpu/drm/loongson/loongson_drv.c
> > index 252be9e25aff..89450c8c9102 100644
> > --- a/drivers/gpu/drm/loongson/loongson_drv.c
> > +++ b/drivers/gpu/drm/loongson/loongson_drv.c
> > @@ -167,6 +167,10 @@ static int loongson_drm_load(struct drm_device *dev, unsigned long flags)
> >  	if (ret)
> >  		dev_err(dev->dev, "Fatal error during modeset init: %d\n", ret);
> >  
> > +	ret = loongson_irq_init(ldev);
> > +	if (ret)
> > +		dev_err(dev->dev, "Fatal error during irq init: %d\n", ret);
> 
> It feel like there should be proper cleanup and error handling on this
> path instead of just printing an error and continuing.

Thank you very much for your advice.

> 
> > +
> >  	drm_kms_helper_poll_init(dev);
> >  	drm_mode_config_reset(dev);
> >  
> 
> regards,
> dan carpenter


------------------------------
Loongson LiChenyang</lichenyang at loongson.cn></dan.carpenter at oracle.com>