[PATCH] staging: rtl8723bs: make if-statement checkpatch.pl conform

Dan Carpenter dan.carpenter at oracle.com
Fri Feb 19 07:01:40 UTC 2021


On Thu, Feb 18, 2021 at 07:50:27PM +0000, Kurt Manucredo wrote:
> Signed-off-by: Kurt Manucredo <fuzzybritches at protonmail.com>
> ---
> 
> The preferred coding style is:
> 	if (!StaAddr)
> 	return;

Above the Signed-off-by line.  Also indenting is wrong.  And it's hard
to understand what you're saying.

> 
> thank you mr. dan carpenter

You're welcome.  (These sorts of comments do go below the --- cut off
line so that's fine.)

regards,
dan carpenter



More information about the devel mailing list