[PATCH v5 0/6] MIPS: ralink: add CPU clock detection and clock driver for MT7621

Stephen Boyd sboyd at kernel.org
Fri Feb 12 03:16:39 UTC 2021


Quoting Sergio Paracuellos (2021-01-17 06:19:36)
> Hi all,
> 
> On Sun, Dec 20, 2020 at 10:37 AM Sergio Paracuellos
> <sergio.paracuellos at gmail.com> wrote:
> >
> >  - Hardcode "xtal" as parent in FIXED macro.
> >  - Change 'else if' clause into 'if' clause since a return statement was
> >    being used in 'mt7621_xtal_recalc_rate'.
> >
> >  NOTES:
> >    - Driver is still being declared using 'CLK_OF_DECLARE' for all the
> >      clocks. I have explored the possibility to make some of them available
> >      afterwards using 'CLK_OF_DECLARE_DRIVER' for top clocks and the rest
> >      using a platform driver. The resulting code was uglier since we only want
> >      to use the same device tree node and the top clocks must be copied again
> >      for the new platform register stuff to properly have a good hierarchy.
> >      New globals needs to be introduced and in this particular case I don't
> >      really see the benefits of doing in this way. I am totally ok to have all
> >      the clocks registered at early stage since from other drivers perspective
> >      we only really need to enable gates. So, I prefer to have them in that
> >      way if it is not a real problem, of course.
> 
> Any comments on this? Is ok to maintain this as it is done in this
> version or should I change this to any other approach taking into
> account my comments in device tree related PATCH? Nothing has been
> suggested there yet.
> 

Please resend. It seems to have fallen off of DT review list.


More information about the devel mailing list