[PATCH] staging: wimax/i2400m: fix coding style issues

Greg KH gregkh at linuxfoundation.org
Wed Feb 3 15:46:04 UTC 2021


On Wed, Feb 03, 2021 at 03:40:06PM +0000, Ayush wrote:
> >
> > - Your patch did many different things all at once, making it difficult
> > to review. All Linux kernel patches need to only do one thing at a
> > time. If you need to do multiple things (such as clean up all coding
> > style issues in a file/driver), do it in a sequence of patches, each
> > one doing only one thing. This will make it easier to review the
> > patches to ensure that they are correct, and to help alleviate any
> > merge issues that larger patches can cause.
> >
> 
> Okay sir, I will break down the patch and send the patch series in v2.
>  
> > - It looks like you did not use your "real" name for the patch on either
> > the Signed-off-by: line, or the From: line (both of which have to
> > match). Please read the kernel file, Documentation/SubmittingPatches
> > for how to do this correctly.
> > 
> 
> Actually my legal name is only "Ayush", I do not have a last name.

Ok, if that is your legal name, that is fine to use, thanks.

greg k-h


More information about the devel mailing list