[PATCH] staging: media: atomisp: pci: reposition braces as per coding style

Sakari Ailus sakari.ailus at linux.intel.com
Fri Apr 30 17:12:41 UTC 2021


Hi Deepak,

On Fri, Apr 30, 2021 at 10:34:37PM +0530, Deepak R Varma wrote:
> On Fri, Apr 30, 2021 at 07:33:27PM +0300, Sakari Ailus wrote:
> > Hi Deepak,
> > 
> > If you're touching all these lines, I might do a little more. Please see
> > the comments below.
> > 
> Hello Sakari,
> I can definitely include other changes, but then it will be many different
> types of changes into a single patch. Will that be okay?
> 
> I was planning to address one issue per patch as I think the volume of
> change is going to be high.  I mentioned that in the notes section of the patch
> message.

I think I'd split the patch into smaller chunks if the result becomes too
big but I don't think it's necessary yet.

Splitting different kinds of simple cleanups into several patches takes
longer time to review when they're touching the same piece of code. As the
chunks in these patches have virtually no dependencies to other chunks,
it's fine to do several kinds of cleanups at once.

-- 
Kind regards,

Sakari Ailus


More information about the devel mailing list