[driver-core:tty-test 9/9] drivers/tty/tty_buffer.c:604:40: error: 'TTY_LOCK_SLAVE' undeclared

kernel test robot lkp at intel.com
Wed Apr 7 20:51:12 UTC 2021


tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git tty-test
head:   bb57c5de81c6feaad869acce7c38b1049115ac75
commit: bb57c5de81c6feaad869acce7c38b1049115ac75 [9/9] tty: move some internal tty lock enums and functions out of tty.h
config: sparc64-randconfig-s032-20210407 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-279-g6d5d9b42-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/commit/?id=bb57c5de81c6feaad869acce7c38b1049115ac75
        git remote add driver-core https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
        git fetch --no-tags driver-core tty-test
        git checkout bb57c5de81c6feaad869acce7c38b1049115ac75
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=sparc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/spinlock.h:59,
                    from include/linux/wait.h:9,
                    from include/linux/wait_bit.h:8,
                    from include/linux/fs.h:6,
                    from include/linux/tty.h:5,
                    from drivers/tty/tty_buffer.c:8:
   drivers/tty/tty_buffer.c: In function 'tty_buffer_set_lock_subclass':
>> drivers/tty/tty_buffer.c:604:40: error: 'TTY_LOCK_SLAVE' undeclared (first use in this function)
     604 |  lockdep_set_subclass(&port->buf.lock, TTY_LOCK_SLAVE);
         |                                        ^~~~~~~~~~~~~~
   include/linux/lockdep.h:233:71: note: in definition of macro 'lockdep_set_subclass'
     233 |  lockdep_init_map_waits(&(lock)->dep_map, #lock, (lock)->dep_map.key, sub,\
         |                                                                       ^~~
   drivers/tty/tty_buffer.c:604:40: note: each undeclared identifier is reported only once for each function it appears in
     604 |  lockdep_set_subclass(&port->buf.lock, TTY_LOCK_SLAVE);
         |                                        ^~~~~~~~~~~~~~
   include/linux/lockdep.h:233:71: note: in definition of macro 'lockdep_set_subclass'
     233 |  lockdep_init_map_waits(&(lock)->dep_map, #lock, (lock)->dep_map.key, sub,\
         |                                                                       ^~~
--
   In file included from include/linux/spinlock.h:59,
                    from include/linux/wait.h:9,
                    from include/linux/wait_bit.h:8,
                    from include/linux/fs.h:6,
                    from include/linux/tty.h:5,
                    from drivers/tty/tty_mutex.c:2:
   drivers/tty/tty_mutex.c: In function 'tty_set_lock_subclass':
>> drivers/tty/tty_mutex.c:59:43: error: 'TTY_LOCK_SLAVE' undeclared (first use in this function)
      59 |  lockdep_set_subclass(&tty->legacy_mutex, TTY_LOCK_SLAVE);
         |                                           ^~~~~~~~~~~~~~
   include/linux/lockdep.h:233:71: note: in definition of macro 'lockdep_set_subclass'
     233 |  lockdep_init_map_waits(&(lock)->dep_map, #lock, (lock)->dep_map.key, sub,\
         |                                                                       ^~~
   drivers/tty/tty_mutex.c:59:43: note: each undeclared identifier is reported only once for each function it appears in
      59 |  lockdep_set_subclass(&tty->legacy_mutex, TTY_LOCK_SLAVE);
         |                                           ^~~~~~~~~~~~~~
   include/linux/lockdep.h:233:71: note: in definition of macro 'lockdep_set_subclass'
     233 |  lockdep_init_map_waits(&(lock)->dep_map, #lock, (lock)->dep_map.key, sub,\
         |                                                                       ^~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for FRAME_POINTER
   Depends on DEBUG_KERNEL && (M68K || UML || SUPERH) || ARCH_WANT_FRAME_POINTERS || MCOUNT
   Selected by
   - LATENCYTOP && DEBUG_KERNEL && STACKTRACE_SUPPORT && PROC_FS && !MIPS && !PPC && !S390 && !MICROBLAZE && !ARM && !ARC && !X86
   - LOCKDEP && DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT && !MIPS && !PPC && !ARM && !S390 && !MICROBLAZE && !ARC && !X86


vim +/TTY_LOCK_SLAVE +604 drivers/tty/tty_buffer.c

1d1d14da12e79a Peter Hurley 2015-01-17  600  
1d1d14da12e79a Peter Hurley 2015-01-17  601  /* slave ptys can claim nested buffer lock when handling BRK and INTR */
1d1d14da12e79a Peter Hurley 2015-01-17  602  void tty_buffer_set_lock_subclass(struct tty_port *port)
1d1d14da12e79a Peter Hurley 2015-01-17  603  {
1d1d14da12e79a Peter Hurley 2015-01-17 @604  	lockdep_set_subclass(&port->buf.lock, TTY_LOCK_SLAVE);
1d1d14da12e79a Peter Hurley 2015-01-17  605  }
e176058f0de53c Peter Hurley 2015-10-17  606  

:::::: The code at line 604 was first introduced by commit
:::::: 1d1d14da12e79a6c05fbe1a975401f0f56c93316 pty: Fix buffer flush deadlock

:::::: TO: Peter Hurley <peter at hurleysoftware.com>
:::::: CC: Greg Kroah-Hartman <gregkh at linuxfoundation.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 30651 bytes
Desc: not available
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20210408/0475ed95/attachment-0001.bin>


More information about the devel mailing list