[driver-core:debugfs_remove_return_value 16/24] drivers/tty/serial/pch_uart.c:1815:9: error: 'port_regs_ops' undeclared

kernel test robot lkp at intel.com
Sat Apr 3 13:16:03 UTC 2021


tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git debugfs_remove_return_value
head:   b133d227ed48382c8cf8f977f69279cf3a0e0ac4
commit: 0ce3084ec1fef72edd1edee6d144626178a47d4a [16/24] tty: serial: pch_uart.c: remove debugfs dentry pointer
config: ia64-randconfig-r034-20210403 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/commit/?id=0ce3084ec1fef72edd1edee6d144626178a47d4a
        git remote add driver-core https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
        git fetch --no-tags driver-core debugfs_remove_return_value
        git checkout 0ce3084ec1fef72edd1edee6d144626178a47d4a
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>

All errors (new ones prefixed by >>):

   In file included from arch/ia64/include/asm/pgtable.h:154,
                    from include/linux/pgtable.h:6,
                    from arch/ia64/include/asm/uaccess.h:40,
                    from include/linux/uaccess.h:11,
                    from arch/ia64/include/asm/sections.h:11,
                    from include/linux/interrupt.h:20,
                    from include/linux/pci.h:38,
                    from drivers/tty/serial/pch_uart.c:9:
   arch/ia64/include/asm/mmu_context.h: In function 'reload_context':
   arch/ia64/include/asm/mmu_context.h:127:41: warning: variable 'old_rr4' set but not used [-Wunused-but-set-variable]
     127 |  unsigned long rr0, rr1, rr2, rr3, rr4, old_rr4;
         |                                         ^~~~~~~
   drivers/tty/serial/pch_uart.c: In function 'pch_uart_init_port':
>> drivers/tty/serial/pch_uart.c:1815:9: error: 'port_regs_ops' undeclared (first use in this function)
    1815 |        &port_regs_ops);
         |         ^~~~~~~~~~~~~
   drivers/tty/serial/pch_uart.c:1815:9: note: each undeclared identifier is reported only once for each function it appears in


vim +/port_regs_ops +1815 drivers/tty/serial/pch_uart.c

  1725	
  1726	static struct eg20t_port *pch_uart_init_port(struct pci_dev *pdev,
  1727						     const struct pci_device_id *id)
  1728	{
  1729		struct eg20t_port *priv;
  1730		int ret;
  1731		unsigned int iobase;
  1732		unsigned int mapbase;
  1733		unsigned char *rxbuf;
  1734		int fifosize;
  1735		int port_type;
  1736		struct pch_uart_driver_data *board;
  1737		char name[32];
  1738	
  1739		board = &drv_dat[id->driver_data];
  1740		port_type = board->port_type;
  1741	
  1742		priv = kzalloc(sizeof(struct eg20t_port), GFP_KERNEL);
  1743		if (priv == NULL)
  1744			goto init_port_alloc_err;
  1745	
  1746		rxbuf = (unsigned char *)__get_free_page(GFP_KERNEL);
  1747		if (!rxbuf)
  1748			goto init_port_free_txbuf;
  1749	
  1750		switch (port_type) {
  1751		case PORT_PCH_8LINE:
  1752			fifosize = 256; /* EG20T/ML7213: UART0 */
  1753			break;
  1754		case PORT_PCH_2LINE:
  1755			fifosize = 64; /* EG20T:UART1~3  ML7213: UART1~2*/
  1756			break;
  1757		default:
  1758			dev_err(&pdev->dev, "Invalid Port Type(=%d)\n", port_type);
  1759			goto init_port_hal_free;
  1760		}
  1761	
  1762		pci_enable_msi(pdev);
  1763		pci_set_master(pdev);
  1764	
  1765		spin_lock_init(&priv->lock);
  1766	
  1767		iobase = pci_resource_start(pdev, 0);
  1768		mapbase = pci_resource_start(pdev, 1);
  1769		priv->mapbase = mapbase;
  1770		priv->iobase = iobase;
  1771		priv->pdev = pdev;
  1772		priv->tx_empty = 1;
  1773		priv->rxbuf.buf = rxbuf;
  1774		priv->rxbuf.size = PAGE_SIZE;
  1775	
  1776		priv->fifo_size = fifosize;
  1777		priv->uartclk = pch_uart_get_uartclk();
  1778		priv->port_type = port_type;
  1779		priv->port.dev = &pdev->dev;
  1780		priv->port.iobase = iobase;
  1781		priv->port.membase = NULL;
  1782		priv->port.mapbase = mapbase;
  1783		priv->port.irq = pdev->irq;
  1784		priv->port.iotype = UPIO_PORT;
  1785		priv->port.ops = &pch_uart_ops;
  1786		priv->port.flags = UPF_BOOT_AUTOCONF;
  1787		priv->port.fifosize = fifosize;
  1788		priv->port.line = board->line_no;
  1789		priv->port.has_sysrq = IS_ENABLED(CONFIG_SERIAL_PCH_UART_CONSOLE);
  1790		priv->trigger = PCH_UART_HAL_TRIGGER_M;
  1791	
  1792		snprintf(priv->irq_name, IRQ_NAME_SIZE,
  1793			 KBUILD_MODNAME ":" PCH_UART_DRIVER_DEVICE "%d",
  1794			 priv->port.line);
  1795	
  1796		spin_lock_init(&priv->port.lock);
  1797	
  1798		pci_set_drvdata(pdev, priv);
  1799		priv->trigger_level = 1;
  1800		priv->fcr = 0;
  1801	
  1802		if (pdev->dev.of_node)
  1803			of_property_read_u32(pdev->dev.of_node, "clock-frequency"
  1804						 , &user_uartclk);
  1805	
  1806	#ifdef CONFIG_SERIAL_PCH_UART_CONSOLE
  1807		pch_uart_ports[board->line_no] = priv;
  1808	#endif
  1809		ret = uart_add_one_port(&pch_uart_driver, &priv->port);
  1810		if (ret < 0)
  1811			goto init_port_hal_free;
  1812	
  1813		snprintf(name, sizeof(name), "uart%d_regs", priv->port.line);
  1814		debugfs_create_file(name, S_IFREG | S_IRUGO, NULL, priv,
> 1815				    &port_regs_ops);
  1816	
  1817		return priv;
  1818	
  1819	init_port_hal_free:
  1820	#ifdef CONFIG_SERIAL_PCH_UART_CONSOLE
  1821		pch_uart_ports[board->line_no] = NULL;
  1822	#endif
  1823		free_page((unsigned long)rxbuf);
  1824	init_port_free_txbuf:
  1825		kfree(priv);
  1826	init_port_alloc_err:
  1827	
  1828		return NULL;
  1829	}
  1830	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 25955 bytes
Desc: not available
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20210403/ef86fa33/attachment-0001.bin>


More information about the devel mailing list