[PATCH] staging: gdm724x: gdm_tty: replaced macro with a function v2

Dan Carpenter dan.carpenter at oracle.com
Wed Sep 2 13:58:32 UTC 2020

On Wed, Sep 02, 2020 at 03:25:59PM +0200, Antoni Przybylik wrote:
> This approach is more elegant and prevents some problems related to
> macros such as operator precedence in expanded expression.
> -------------------------------------------------------------------
> Changed return type to bool and removed inline sepcifier.
> Signed-off-by: Antoni Przybylik <antoni.przybylik at wp.pl>
> ---
See this line.

No that doesn't work at all.  Try applying your patch and reviewing the
git log.  Look the the email archive to see how to send a v2 patch.

1) subject says [PATCH v2]
2) comments under the --- line

>  drivers/staging/gdm724x/gdm_tty.c | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)

dan carpenter

More information about the devel mailing list