[PATCH v6 5/9] media: staging: rkisp1: remove unecessary clocks
robh+dt at kernel.org
Thu Oct 29 20:04:16 UTC 2020
On Tue, Oct 20, 2020 at 2:39 PM Helen Koike <helen.koike at collabora.com> wrote:
> aclk_isp_wrap is a child of aclk_isp, and hclk_isp_wrap is a child of
> hclk_isp, thus we can remove parents from the list.
> Also, for the isp0, we only need the ISP clock, ACLK and HCLK.
> In the future we'll need a pixel clock for RK3288 and RK3399, and a JPEG
> clock for RK3288.
> So with the goal to cleanup the dt-bindings and remove it from staging,
> simplify clock names to isp, aclk and hclk.
> Assigned clocks are meant to refer to the full path in the clock tree,
> i.e. the leaf in the tree.
> For instance, in RK3399, the clock responsible for ACLK (ISP AXI CLOCK)
> is aclk_isp0_wrapper.
> For reference, this is the isp clock topology on RK3399:
> Signed-off-by: Helen Koike <helen.koike at collabora.com>
> Reviewed-by: Tomasz Figa <tfiga at chromium.org>
> Changes in V6:
> - Define clocks in the top level, and use if/else schema to define how
> many for each compatible as sugested by Rob Herring on
> .../bindings/media/rockchip-isp1.yaml | 44 +++++++++++++------
> drivers/staging/media/rkisp1/rkisp1-dev.c | 8 ++--
> 2 files changed, 33 insertions(+), 19 deletions(-)
Reviewed-by: Rob Herring <robh at kernel.org>
More information about the devel