[PATCH v2] staging: fieldbus: Use %pM format specifier for MAC addresses

Andy Shevchenko andriy.shevchenko at linux.intel.com
Thu Oct 29 11:02:29 UTC 2020

On Wed, Oct 28, 2020 at 07:39:58PM -0400, Sven Van Asbroeck wrote:
> On Tue, Oct 27, 2020 at 2:34 PM Andy Shevchenko
> <andriy.shevchenko at linux.intel.com> wrote:
> >
> > +       return snprintf(buf, max_size, "%pM\n", response.addr);
> Judging from a few Outreachy patches that have hit my inbox, snprintf() is
> considered unsafe in a sysfs_get callback. It should be replaced by
> scnprintf() or even better, sysfs_emit(), which was recently introduced
> to address sprintf-variant issues in sysfs callbacks.

It's already applied, I think you can send a follow up for above,
which is good point, but not the scope of the patch (although
they might have been unified together).

With Best Regards,
Andy Shevchenko

More information about the devel mailing list