[Outreachy kernel] Re: [PATCH v2 1/2] staging: kpc2000: kpc_dma: rearrange lines exceeding 100 columns

Deepak R Varma mh12gx2825 at gmail.com
Mon Oct 26 13:58:19 UTC 2020


On Mon, Oct 26, 2020 at 04:16:52AM +0000, Matthew Wilcox wrote:
> On Mon, Oct 26, 2020 at 09:34:53AM +0530, Deepak R Varma wrote:
> > > -		dev_dbg(&eng->pldev->dev, "Handling completed descriptor %p (acd = %p)\n", cur, cur->acd);
> > > +		dev_dbg(&eng->pldev->dev, "Handling completed descriptor %p (acd = %p)\n",
> > > +			cur,
> > > +			cur->acd);
> 
> Why do you put 'cur' and 'cur->acd' on different lines?

Hello,
I was thinking it makes it more readable. However, I understand your
comment and will rearrange the changes accordingly. Thank you for
pointing it out.

> 
> > > -	rv = request_irq(eng->irq, ndd_irq_handler, IRQF_SHARED, KP_DRIVER_NAME_DMA_CONTROLLER, eng);
> > > +	rv = request_irq(eng->irq,
> > > +			 ndd_irq_handler,
> > > +			 IRQF_SHARED,
> > > +			 KP_DRIVER_NAME_DMA_CONTROLLER,
> > > +			 eng);
> 
> Likewise.  I'd do:
> 
> 	rv = request_irq(eng->irq, ndd_irq_handler, IRQF_SHARED,
> 			KP_DRIVER_NAME_DMA_CONTROLLER, eng);
> 

Yes, will correct all such occurrences and resend another version.

Thank you,
Deepak.


More information about the devel mailing list