[Outreachy kernel] Clean up query: greybus/audio_manager_module.c

Greg KH gregkh at linuxfoundation.org
Thu Oct 22 05:29:31 UTC 2020


On Thu, Oct 22, 2020 at 09:07:01AM +0530, Deepak R Varma wrote:
> Hello,
> I am reviewing the file: drivers/staging/greybus/audio_manager_module.c
> and have found that there are several gb_audio_module_*_show functions
> that accept "struct gb_audio_manager_module_attribute * " as a function
> parameter. However, this parameter is not used and should not be
> necessary. Would you suggest cleaning up such functions.

Try removing it and see why it is really needed to be there :)

good luck!

greg k-h


More information about the devel mailing list