[PATCH v2] staging: vchiq: Fix list_for_each exit tests

Nicolas Saenz Julienne nsaenzjulienne at suse.de
Thu Oct 8 09:38:04 UTC 2020


On Tue, 2020-10-06 at 16:47 +0300, Dan Carpenter wrote:
> After a list_for_each_entry() loop, the list iterator is always non-NULL
> so these conditions don't work.  If the "waiter" is not found then this
> results in an out of bounds access.
> 
> I have fixed it by introducing a new "found" variable.  In one case, I
> used an else statement for readability.
> 
> Fixes: 46e4b9ec4fa4 ("staging: vchiq_arm: use list_for_each_entry when accessing bulk_waiter_list")
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
> ---

Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne at suse.de>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20201008/d00624f8/attachment.asc>


More information about the devel mailing list