[PATCH v4] staging: qlge: fix build breakage with dumping enabled

Benjamin Poirier benjamin.poirier at gmail.com
Sun Oct 4 23:59:16 UTC 2020


On 2020-10-04 23:22 +0800, Coiby Xu wrote:
> On Sat, Oct 03, 2020 at 02:53:48PM +0900, Benjamin Poirier wrote:
> > On 2020-10-03 07:59 +0800, Coiby Xu wrote:
> > > This fixes commit 0107635e15ac
> > > ("staging: qlge: replace pr_err with netdev_err") which introduced an
> > > build breakage of missing `struct ql_adapter *qdev` for some functions
> > > and a warning of type mismatch with dumping enabled, i.e.,
> > > 
> > > $ make CFLAGS_MODULE="-DQL_ALL_DUMP -DQL_OB_DUMP -DQL_CB_DUMP \
> > >     -DQL_IB_DUMP -DQL_REG_DUMP -DQL_DEV_DUMP" M=drivers/staging/qlge
> > > 
> > > qlge_dbg.c: In function ‘ql_dump_ob_mac_rsp’:
> > > qlge_dbg.c:2051:13: error: ‘qdev’ undeclared (first use in this function); did you mean ‘cdev’?
> > >  2051 |  netdev_err(qdev->ndev, "%s\n", __func__);
> > >       |             ^~~~
> > > qlge_dbg.c: In function ‘ql_dump_routing_entries’:
> > > qlge_dbg.c:1435:10: warning: format ‘%s’ expects argument of type ‘char *’, but argument 3 has type ‘int’ [-Wformat=]
> > >  1435 |        "%s: Routing Mask %d = 0x%.08x\n",
> > >       |         ~^
> > >       |          |
> > >       |          char *
> > >       |         %d
> > >  1436 |        i, value);
> > >       |        ~
> > >       |        |
> > >       |        int
> > > qlge_dbg.c:1435:37: warning: format ‘%x’ expects a matching ‘unsigned int’ argument [-Wformat=]
> > >  1435 |        "%s: Routing Mask %d = 0x%.08x\n",
> > >       |                                 ~~~~^
> > >       |                                     |
> > >       |                                     unsigned int
> > > 
> > > Note that now ql_dump_rx_ring/ql_dump_tx_ring won't check if the passed
> > > parameter is a null pointer.
> > > 
> > > Fixes: 0107635e15ac ("staging: qlge: replace pr_err with netdev_err")
> > > Reported-by: Benjamin Poirier <benjamin.poirier at gmail.com>
> > > Suggested-by: Benjamin Poirier <benjamin.poirier at gmail.com>
> > > Signed-off-by: Coiby Xu <coiby.xu at gmail.com>
> > > ---
> > 
> > Reviewed-by: Benjamin Poirier <benjamin.poirier at gmail.com>
> 
> Thank you! Btw, I guess when this patch is picked, the "Reviewed-by" tag
> will also be included. So I needn't to send another patch, am I right?

I think so. Maintainers usually take care of adding attribution tags
from followup emails and that's what Greg has done for your previous
qlge patch it looks like.


More information about the devel mailing list