[PATCH 09/11] media: atomisp: partially get rid of one abstraction layer

Sakari Ailus sakari.ailus at linux.intel.com
Tue May 26 07:26:05 UTC 2020


Hi Mauro,

On Mon, May 25, 2020 at 08:56:08AM +0200, Mauro Carvalho Chehab wrote:
> The very same macros are defined as CSS_foo and IA_CSS_foo.
> 
> Remove this abstraction, as it just make things confusing,
> for no good reason.

I think this boils down to which prefix should the uAPI structs of this
driver use. I'd prefer atomisp_something, ia_css has been used internally,
and that probably has been there in later firmware versions (vs. just css).

At this point removing the duplication makes sense though, so I'm not
proposing changes here.

-- 
Sakari Ailus


More information about the devel mailing list