[PATCH] rtl8723bs: core: fix a coding style error

heshuai1 hexiaoshuaishuai at gmail.com
Fri May 15 09:40:44 UTC 2020


Fix this coding style error reported by checkpatch.pl:
  ERROR: do not use assignment in if condition
  #1120: FILE: drivers/staging/rtl8723bs/core/rtw_ieee80211.c:1120::
  +	 if ((addr = of_get_property(np, "local-mac-address", &len)) &&

Signed-off-by: heshuai1 <heshuai1 at xiaomi.com>
---
 drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
index ca98274..06be1d4 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
@@ -1117,8 +1117,8 @@ void rtw_macaddr_cfg(struct device *dev, u8 *mac_addr)
 	}
 
 	if (is_broadcast_ether_addr(mac) || is_zero_ether_addr(mac)) {
-		if ((addr = of_get_property(np, "local-mac-address", &len)) &&
-		    len == ETH_ALEN) {
+		addr = of_get_property(np, "local-mac-address", &len);
+		if (addr && len == ETH_ALEN) {
 			ether_addr_copy(mac_addr, addr);
 		} else {
 			eth_random_addr(mac_addr);
-- 
2.7.4



More information about the devel mailing list