[PATCH] staging: rtl8723bs: os_dep: Cleanup pointer casting code style

Dan Carpenter dan.carpenter at oracle.com
Wed May 6 10:25:12 UTC 2020


On Sat, May 02, 2020 at 08:47:50AM +0800, Yu Jian Wu wrote:
> Cleanup by adding a space between type and pointer, in accordance with
> checkpatch.pl message "(foo*)" should be "(foo *)".
> 
> Signed-off-by: Yu Jian Wu <yujian.wu1 at gmail.com>
> ---
>  .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c    | 16 ++++++++--------
>  drivers/staging/rtl8723bs/os_dep/recv_linux.c    |  2 +-
>  2 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> index b037868fbf22..8377bc75e308 100644
> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> @@ -98,7 +98,7 @@ static struct ieee80211_channel rtw_2ghz_channels[] = {
>  
>  static void rtw_2g_channels_init(struct ieee80211_channel *channels)
>  {
> -	memcpy((void*)channels, (void*)rtw_2ghz_channels,
> +	memcpy((void *)channels, (void *)rtw_2ghz_channels,

These casts aren't required.  It would be better to remove them.

	memcpy(channels, rtw_2ghz_channels,
	       sizeof(*channel) * RTW_2G_CHANNELS_NUM);

Same for a bunch of the others as well.

regards,
dan carpenter



More information about the devel mailing list