[Outreachy kernel] [PATCH v5] staging: vt6656: add error code handling to unused variable

John B. Wyatt IV jbwyatt4 at gmail.com
Mon Mar 30 21:47:18 UTC 2020


On Mon, 2020-03-30 at 23:06 +0200, Stefano Brivio wrote:
> On Mon, 30 Mar 2020 11:45:17 -0700
> "John B. Wyatt IV" <jbwyatt4 at gmail.com> wrote:
> 
> > Add error code handling to unused 'ret' variable that was never
> > used.
> > Return an error code from functions called within
> > vnt_radio_power_on.
> > 
> > Issue reported by coccinelle (coccicheck).
> > 
> > Suggested-by: Quentin Deslandes <quentin.deslandes at itdev.co.uk>
> > Suggested-by: Stefano Brivio <sbrivio at redhat.com>
> > Reviewed-by: Quentin Deslandes <quentin.deslandes at itdev.co.uk>
> > Signed-off-by: John B. Wyatt IV <jbwyatt4 at gmail.com>
> > ---
> > v5: Remove Suggested-by: Julia Lawall above seperator line.
> >     Remove break; statement in switch block.
> >     break; removal checked by both gcc compile and checkpatch.
> > 
> > [...]
> > 
> > @@ -734,14 +738,15 @@ int vnt_radio_power_on(struct vnt_private
> > *priv)
> >  	case RF_VT3226:
> >  	case RF_VT3226D0:
> >  	case RF_VT3342A0:
> > -		vnt_mac_reg_bits_on(priv, MAC_REG_SOFTPWRCTL,
> > -				    (SOFTPWRCTL_SWPE2 |
> > SOFTPWRCTL_SWPE3));
> > +		ret = vnt_mac_reg_bits_on(priv, MAC_REG_SOFTPWRCTL,
> > +					  (SOFTPWRCTL_SWPE2 | 
> > +					  SOFTPWRCTL_SWPE3));
> >  		break;
> >  	}
> > +	if (ret)
> > +		return ret;
> 
> Did you send the wrong version perhaps?
> 

Yes. My apologies. Please see v6.



More information about the devel mailing list