[Outreachy kernel] [PATCH] staging: rtl8723bs: rtw_cmd: Compress lines for immediate return

Stefano Brivio sbrivio at redhat.com
Mon Mar 30 06:47:52 UTC 2020


On Thu, 26 Mar 2020 02:52:53 +0530
Simran Singhal <singhalsimran0 at gmail.com> wrote:

> Compress two lines into a single line if immediate return statement is found.
> It also removes variable cmd_obj as it is no longer needed.
> 
> It is done using script Coccinelle.

This should be consistent. What does "it" refer to, now? If you start
with an imperative mode, switching to indicative makes it hard to
follow.

By the way, Coccinelle is not exactly a script. Saying something is
detected by Coccinelle is enough, you don't need to qualify that
further.

-- 
Stefano



More information about the devel mailing list