[PATCH v4 5/6] staging: mt7621-pci: release gpios after pci initialization

Chuanhong Guo gch981213 at gmail.com
Fri Mar 20 15:39:35 UTC 2020


Hi!

On Fri, Mar 20, 2020 at 11:29 PM Sergio Paracuellos
<sergio.paracuellos at gmail.com> wrote:
> > This pin conflict comes from incorrectly occupying pins that are not
> > used by pcie,
> > and should be fixed by not occupying those pins in the first place.
> > Releasing all
> > gpios isn't the proper way to go.
>
> So, you are saying we just have to get gpio for the pin 19 and forget
> about the others?

Not really "forget about the others". We should use only gpio19
in mt7621.dtsi and others should be added to device dts if it's
actually needed. e.g. if pcie cards can't be detected on a specific
board without gpio7 and/or gpio8, override gpio-resets in dts of
that board.

-- 
Regards,
Chuanhong Guo


More information about the devel mailing list