[PATCH] staging: greybus: Use scnprintf() for avoiding potential buffer overflow
Dan Carpenter
dan.carpenter at oracle.com
Thu Mar 12 14:51:11 UTC 2020
On Wed, Mar 11, 2020 at 10:58:14AM +0100, Johan Hovold wrote:
> On Wed, Mar 11, 2020 at 10:19:06AM +0100, Takashi Iwai wrote:
> > Since snprintf() returns the would-be-output size instead of the
> > actual output size, the succeeding calls may go beyond the given
> > buffer limit. Fix it by replacing with scnprintf().
> >
> > Signed-off-by: Takashi Iwai <tiwai at suse.de>
> > ---
> > drivers/staging/greybus/tools/loopback_test.c | 24 ++++++++++++------------
>
> Thanks for the fix.
>
> Would you mind resending with a "staging: greybus: loopback_test:"
> prefix since this is not a subsystem wide issue, bur rather a bug in a
> specific user-space tool?
I'm surprised that user-space even has scnprintf().
regards,
dan carpenter
More information about the devel
mailing list