[PATCH v3 0/5] staging: mt7621-pci: re-do reset boot process
Sergio Paracuellos
sergio.paracuellos at gmail.com
Thu Mar 12 09:00:41 UTC 2020
Some time ago Greg Ungerer reported some random hangs using
the staging mt7621-pci driver:
See:
* http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2019-June/134947.html
Try to fix that is the main motivation of this patch series.
Also in openwrt there is a driver for mt7621-pci which seems was rewritten
from scratch (for kernel 4.14) by Ryder Lee and Weijie Gao from mediatek.
There the approach for reset assert-deassert process is to set as 'gpio'
the function for all the 'pcie' group for the pinctrl driver and use those
gpio's as a reset for the end points. The driver I am talking about is still
using legacy pci and legacy gpio kernel interfaces. IMHO, the correct thing
to do is make this staging driver properly clean and functional and put it
in its correct place in the mainline.
See:
* https://gist.github.com/dengqf6/7a9e9b4032d99f1a91dd9256c8a65c36
Because of all of this this patch series tries to avoid random hangs of boot
trying to use the 'reset-gpios' approach.
Changes are being tested by openwrt people and seems to work.
Hope this helps.
Changes in v3:
* Avoid to fail if gpio descriptor fails on get.
* re-do PATCH 1 commit message.
* Take into account gpio low polarity on request and assert and deassert.
* Review error path of driver to properly release gpio's resources.
Changes in v2:
* restore configuration for pers mode to GPIO.
* Avoid to read FTS_NUM register in reset state.
* Release gpio's patch added
Best regards,
Sergio Paracuellos
Sergio Paracuellos (5):
staging: mt7621-pci: use gpios for properly reset
staging: mt7621-pci: change value for 'PERST_DELAY_US'
staging: mt7621-dts: make use of 'reset-gpios' property for pci
staging: mt7621-pci: bindings: update doc accordly to last changes
staging: mt7621-pci: release gpios after pci initialization
drivers/staging/mt7621-dts/mt7621.dtsi | 11 +-
.../mt7621-pci/mediatek,mt7621-pci.txt | 7 +-
drivers/staging/mt7621-pci/pci-mt7621.c | 107 +++++++++++-------
3 files changed, 80 insertions(+), 45 deletions(-)
--
2.25.1
More information about the devel
mailing list