[Outreachy kernel] [PATCH v4] Staging: rtl8188eu: rtw_mlme: Add space around operators

Stefano Brivio sbrivio at redhat.com
Wed Mar 11 17:04:28 UTC 2020


On Wed, 11 Mar 2020 18:47:42 +0530
Shreeya Patel <shreeya.patel23498 at gmail.com> wrote:

> Add space around operators for improving the code
> readability.
> Reported by checkpatch.pl
> 
> git diff -w shows no difference.
> diff of the .o files before and after the changes shows no difference.
> 
> Signed-off-by: Shreeya Patel <shreeya.patel23498 at gmail.com>

This looks good to me. Further clean-ups here could probably make this
look less messy (there are long lines, unnecessary parentheses that are
rather confusing, especially on that 4/5 factor, "magic" constants that
might make sense to figure out the meaning of, etc.).

Reviewed-by: Stefano Brivio <sbrivio at redhat.com>

-- 
Stefano



More information about the devel mailing list