[PATCH] staging: greybus: Use scnprintf() for avoiding potential buffer overflow

Johan Hovold johan at kernel.org
Wed Mar 11 10:09:03 UTC 2020


On Wed, Mar 11, 2020 at 11:02:33AM +0100, Takashi Iwai wrote:
> On Wed, 11 Mar 2020 10:58:14 +0100,
> Johan Hovold wrote:
> > 
> > On Wed, Mar 11, 2020 at 10:19:06AM +0100, Takashi Iwai wrote:
> > > Since snprintf() returns the would-be-output size instead of the
> > > actual output size, the succeeding calls may go beyond the given
> > > buffer limit.  Fix it by replacing with scnprintf().
> > > 
> > > Signed-off-by: Takashi Iwai <tiwai at suse.de>
> > > ---
> > >  drivers/staging/greybus/tools/loopback_test.c | 24 ++++++++++++------------
> > 
> > Thanks for the fix.
> > 
> > Would you mind resending with a "staging: greybus: loopback_test:"
> > prefix since this is not a subsystem wide issue, bur rather a bug in a
> > specific user-space tool?
> 
> OK, will do that.

Thanks.

Perhaps you should replace the snprintf() at the start of the function
in question as well by the way.

Johan


More information about the devel mailing list