[PATCH] staging: comedi: drivers: fix condition with no effect

Saurav Girepunje saurav.girepunje at gmail.com
Sat Jan 25 13:15:35 UTC 2020


fix warning reorted by coccicheck
WARNING: possible condition with no effect (if == else)

Signed-off-by: Saurav Girepunje <saurav.girepunje at gmail.com>
---
  drivers/staging/comedi/drivers/das1800.c | 6 ------
  1 file changed, 6 deletions(-)

diff --git a/drivers/staging/comedi/drivers/das1800.c b/drivers/staging/comedi/drivers/das1800.c
index f16aa7e9..7ab72e8 100644
--- a/drivers/staging/comedi/drivers/das1800.c
+++ b/drivers/staging/comedi/drivers/das1800.c
@@ -1299,12 +1299,6 @@ static int das1800_attach(struct comedi_device *dev,
  			outb(DAC(i), dev->iobase + DAS1800_SELECT);
  			outw(0, dev->iobase + DAS1800_DAC);
  		}
-	} else if (board->id == DAS1800_ID_AO) {
-		/*
-		 * 'ao' boards have waveform analog outputs that are not
-		 * currently supported.
-		 */
-		s->type		= COMEDI_SUBD_UNUSED;
  	} else {
  		s->type		= COMEDI_SUBD_UNUSED;
  	}
-- 
1.9.1



More information about the devel mailing list