[PATCH] staging: exfat: remove fs_func struct.

Greg Kroah-Hartman gregkh at linuxfoundation.org
Wed Jan 22 08:57:37 UTC 2020


On Fri, Jan 17, 2020 at 03:20:46PM +0900, T.Kohada wrote:
> Remove 'fs_func struct' and change indirect calls to direct calls.
> 
> The following issues are described in exfat's TODO.
> > Create helper function for exfat_set_entry_time () and
> > exfat_set_entry_type () because it's sort of ugly to be calling the same functionn directly and other code calling through  the fs_func struc ponters ...
> 
> The fs_func struct was used for switching the helper functions of fat16/fat32/exfat.
> Now, it has lost the role of switching, just making the code less readable.
> 
> Signed-off-by: T.Kohada <Kohada.Tetsuhiro at dc.MitsubishiElectric.co.jp>

We need a "full" name here, not just an abbreviation, use what you would
for a document.

Also the patch does not apply to the linux-next tree at all, so I can't
take it.  Please rebase and resend.

thanks,

greg k-h


More information about the devel mailing list