[PATCH 2/5] staging: vt6656: correct return of vnt_init_registers.

Quentin Deslandes quentin.deslandes at itdev.co.uk
Mon Jan 6 22:02:13 UTC 2020


On 01/03/20 14:09:51, Dan Carpenter wrote:
> On Fri, Dec 20, 2019 at 09:15:09PM +0000, Malcolm Priestley wrote:
> > The driver standard error returns remove bool false conditions.
> > 
> > Cc: stable <stable at vger.kernel.org> # v5.3+
> > Signed-off-by: Malcolm Priestley <tvboxspy at gmail.com>
> 
> Fixes: 07ba60a15843 ("staging: vt6656: clean-up registers initialization error path")
> 
> The other part of that bug was fixed silently in commit 987d864a2363
> ("staging: vt6656: manage error path during device initialization").
> I'm quite embarrassed that I didn't catch these during review...  It's
> the obvious bug right?  "You have reversed the return values but not
> updated any of the callers."  *Egg on my face*.
> 
> regards,
> dan carpenter
> 

That one is ugly, my bad.

The fix looks good to me, and as Dan said the other part has already
been fixed.

Reviewed-by: Quentin Deslandes <quentin.deslandes at itdev.co.uk>

Regards,
Quentin Deslandes


More information about the devel mailing list