[PATCH 2/5] staging: vt6656: correct return of vnt_init_registers.
Dan Carpenter
dan.carpenter at oracle.com
Fri Jan 3 11:09:51 UTC 2020
On Fri, Dec 20, 2019 at 09:15:09PM +0000, Malcolm Priestley wrote:
> The driver standard error returns remove bool false conditions.
>
> Cc: stable <stable at vger.kernel.org> # v5.3+
> Signed-off-by: Malcolm Priestley <tvboxspy at gmail.com>
Fixes: 07ba60a15843 ("staging: vt6656: clean-up registers initialization error path")
The other part of that bug was fixed silently in commit 987d864a2363
("staging: vt6656: manage error path during device initialization").
I'm quite embarrassed that I didn't catch these during review... It's
the obvious bug right? "You have reversed the return values but not
updated any of the callers." *Egg on my face*.
regards,
dan carpenter
More information about the devel
mailing list