[PATCH] staging: vc04_services: Fix wrong early return in next_service_by_instance()

Marcelo Diop-Gonzalez marcgonzalez at google.com
Tue Feb 18 14:44:50 UTC 2020


On Mon, Feb 17, 2020 at 5:40 AM Dan Carpenter <dan.carpenter at oracle.com> wrote:
>
> On Thu, Feb 13, 2020 at 02:40:01PM -0500, Marcelo Diop-Gonzalez wrote:
> > If kref_get_unless_zero() fails, we should keep looking for the
> > next service, since the callers of this function expect that a NULL
> > return value means there are no more.
> >
> > Signed-off-by: Marcelo Diop-Gonzalez <marcgonzalez at google.com>
> > ---
>
> Please use a Fixes tag.
>
> Fixes: a2203cfe0d84 ("staging: vc04_services: don't increment service refcount when it's not needed")

Ah yeah, forgot about that!

>
> That way we know it doesn't need to be backported.
>
> regards,
> dan carpenter
>


More information about the devel mailing list