[PATCH 09/20] staging: wfx: stop changing filtering rule in wfx_hw_scan()

Jerome Pouiller Jerome.Pouiller at silabs.com
Wed Apr 15 16:11:36 UTC 2020


From: Jérôme Pouiller <jerome.pouiller at silabs.com>

It is not very clear why driver ask to firmware to stop filtering probe
request during scan. It is particularly weird because scan is not
supported in AP mode. In add, it does not restore previous filtering
state after scanning.

It seems to be a mistake and should be dropped.

Signed-off-by: Jérôme Pouiller <jerome.pouiller at silabs.com>
---
 drivers/staging/wfx/scan.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/wfx/scan.c b/drivers/staging/wfx/scan.c
index 0c7f4eef045c..276fdacd7143 100644
--- a/drivers/staging/wfx/scan.c
+++ b/drivers/staging/wfx/scan.c
@@ -89,7 +89,6 @@ void wfx_hw_scan_work(struct work_struct *work)
 	mutex_lock(&wvif->wdev->conf_mutex);
 	mutex_lock(&wvif->scan_lock);
 	update_probe_tmpl(wvif, &hw_req->req);
-	wfx_fwd_probe_req(wvif, true);
 	chan_cur = 0;
 	do {
 		ret = send_scan_req(wvif, &hw_req->req, chan_cur);
-- 
2.25.1



More information about the devel mailing list