[PATCH 5/8] staging: rtl8188eu: Remove function rtw_modular64()
Ivan Safonov
isaf21 at yandex.ru
Sun Apr 12 13:34:08 UTC 2020
> Remove function rtw_modular64 as all it does is call do_div.
This is wrong. Macro do_div(x, y) change first argument x, but
rtw_modular64(x, y) preserve it.
> + tsf = pmlmeext->TSFValue - do_div(pmlmeext->TSFValue, (pmlmeinfo->bcn_interval*1024)) - 1024; /* us */
rounddown(pmlmeext->TSFValue, pmlmeinfo->bcn_interval * 1024) - 1024
is a better replacement for
> - tsf = pmlmeext->TSFValue - rtw_modular64(pmlmeext->TSFValue, (pmlmeinfo->bcn_interval*1024)) - 1024; /* us */
Patch '[PATCH 01/10] staging: rtl8723bs: Remove function
rtw_modular64()' have same bug.
Ivan Safonov.
More information about the devel
mailing list