[PATCH 1/2] staging: rtl8188eu: remove unnecessary asignment
Dan Carpenter
dan.carpenter at oracle.com
Mon Apr 6 11:26:47 UTC 2020
On Mon, Apr 06, 2020 at 02:25:20PM +0300, Dan Carpenter wrote:
> On Sun, Apr 05, 2020 at 01:22:29PM +0200, Michael Straube wrote:
> > Remove unnecessary asignment in SwLedBlink1(). The code path with the
> > asignment 'pLed->BlinkTimes = 0' is only executed when
> > 'pLed->BlinkTimes' is already zero and the value is not changed between
> > the test 'if (pLed->BlinkTimes == 0)' and the asignment.
> >
>
> Better to get rid of the bStopBlinking variable and this becomes more
> obvious.
Oh, never mind. You did that in patch 2. This is fine then.
Reviewed-by: Dan Carpenter <dan.carpenter at oracle.com>
regards,
dan carpenter
More information about the devel
mailing list