[PATCH v3] staging: wilc1000: Use crc7 in lib/ rather than a private copy

[Ajay.Kathat at microchip.com]

Hi Dan,

On 02/04/20 1:57 pm, Dan Carpenter wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Thu, Mar 26, 2020 at 03:23:36PM +0000, Ajay.Kathat at microchip.com wrote:
>> From: George Spelvin <lkml at SDF.ORG>
>>
>> The code in lib/ is the desired polynomial, and even includes
>> the 1-bit left shift in the table rather than needing to code
>> it explicitly.
>>
>> While I'm in Kconfig, add a description of what a WILC1000 is.
>> Kconfig questions that require me to look up a data sheet to
>> find out that I probably don't have one are a pet peeve.
>>
> 
> I don't know how this patch made it through two versions without anyone
> complaining that this paragraph should be done as a separate patch...
> 

The first two version of patches were not submitted to devel at driverdev
mailing list. I too missed the point to keep the Kconfig changes in
separate patch.

>> Cc: Adham Abozaeid <adham.abozaeid at microchip.com>
>> Cc: linux-wireless at vger.kernel.org
>> Reviewed-by: Ajay Singh <ajay.kathat at microchip.com>
>> Signed-off-by: George Spelvin <lkml at sdf.org>
>> ---
> 
> This should have you Signed-off-by.  The Reviewed-by is kind of assumed
> so you can drop that bit.  But everyone who touches a patch needs to
> add their signed off by.
> 

Thanks, I will make a note of it.

Regards
Ajay