[PATCH] staging: rtl8192u: fix multiple memory leaks on error path
Markus Elfring
Markus.Elfring at web.de
Fri Sep 27 16:09:09 UTC 2019
> In rtl8192_tx on error handling path allocated urbs and also skb should
> be released.
Can this change description be improved?
How do you think about to add the tag “Fixes” here?
> @@ -1588,7 +1590,12 @@ short rtl8192_tx(struct net_device *dev, struct sk_buff *skb)
> RT_TRACE(COMP_ERR, "Error TX URB %d, error %d",
> atomic_read(&priv->tx_pending[tcb_desc->queue_index]),
> status);
> - return -1;
> +
> +error:
> + dev_kfree_skb_any(skb);
…
Would an other label be more appropriate according to the Linux coding style?
Regards,
Markus
More information about the devel
mailing list