[PATCH v2] staging: greybus: loopback_test: Adding missing brackets into if..else block

Greg KH gregkh at linuxfoundation.org
Mon Sep 9 16:09:52 UTC 2019


On Mon, Sep 09, 2019 at 02:32:44PM +0000, Julio Faracco wrote:
> Inside a block of if..else conditional, else structure does not contain
> brackets. This is not following regular policies of kernel coding style.
> All parts of this conditional blocks should respect brackets inclusion.
> This commit removes some blank spaces that are not following brackets
> policies too.

Whenever you say "too" or "also" that's a huge hint that you should
break the patch up into multiple patches.

Please do that here, only do "one logical thing" per patch.

thanks,

greg k-h


More information about the devel mailing list