[PATCH] Fixed parentheses malpractice in apex_driver.c
dan.carpenter at oracle.com
Sat Sep 7 14:38:49 UTC 2019
You need a subject prefix. It should be something like:
[PATCH] Staging: gasket: Fix parentheses malpractice in apex_driver.c
Generally "Fix" is considered better style than "Fixed". We aren't
going to care about that in staging, but the patch prefix is mandatory
so you will need to redo it anyway and might as well fix that as well.
On Fri, Sep 06, 2019 at 08:38:01PM +0200, volery wrote:
> There were some parentheses at the end of lines, which I took care of.
> This is my first patch.
Put this sort of comments after the --- cut off line
> Signed-off-by: Sandro Volery <sandro at volery.com>
Put it here. It will be removed when we apply the patch so it won't
be recorded in the git log.
> drivers/staging/gasket/apex_driver.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
Joe's comments are, of course, correct as well.
More information about the devel