[PATCH 12/21] erofs: kill verbose debug info in erofs_fill_super

Gao Xiang gaoxiang25 at huawei.com
Mon Sep 2 12:18:34 UTC 2019


Hi Christoph,

On Mon, Sep 02, 2019 at 05:14:24AM -0700, Christoph Hellwig wrote:
> On Sun, Sep 01, 2019 at 01:51:21PM +0800, Gao Xiang wrote:
> > From: Gao Xiang <gaoxiang25 at huawei.com>
> > 
> > As Christoph said [1], "That is some very verbose
> > debug info.  We usually don't add that and let
> > people trace the function instead. "
> 
> Note that this applies to most of the infoln users as far as
> I can tell.  And if you want to keep some of those I think you
> should converted them to use pr_info directly, and also print
> sb->s_id as a prefix before the actual message so that the user
> knows which file system is affected.

Thanks for your suggestion...

I think I will turn them into erofs_errln and etc...
and print sb->s_id as a prefix...

Thanks,
Gao Xiang




More information about the devel mailing list