[PATCH 04/21] erofs: kill __packed for on-disk structures

Christoph Hellwig hch at infradead.org
Mon Sep 2 12:06:58 UTC 2019


On Sun, Sep 01, 2019 at 01:51:13PM +0800, Gao Xiang wrote:
> From: Gao Xiang <gaoxiang25 at huawei.com>
> 
> As Christoph suggested "Please don't add __packed" [1],
> remove all __packed except struct erofs_dirent here.
> 
> Note that all on-disk fields except struct erofs_dirent
> (12 bytes with a 8-byte nid) in EROFS are naturally aligned.

Thanks.  The users of various architectures where this generates a lot
better code will thank you.


More information about the devel mailing list