[PATCH v2 1/3] staging: wfx: Make function 'sram_write_dma_safe','load_firmware_secure' static
Jerome Pouiller
Jerome.Pouiller at silabs.com
Wed Oct 9 14:04:47 UTC 2019
On Wednesday 9 October 2019 15:43:31 CEST zhengbin wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
>
> Fix sparse warnings:
>
> drivers/staging/wfx/fwio.c:83:5: warning: symbol 'sram_write_dma_safe' was not declared. Should it be static?
> drivers/staging/wfx/fwio.c:229:5: warning: symbol 'load_firmware_secure' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci at huawei.com>
> Signed-off-by: zhengbin <zhengbin13 at huawei.com>
> ---
> drivers/staging/wfx/fwio.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/wfx/fwio.c b/drivers/staging/wfx/fwio.c
> index 8fb4a9f..6d82c62 100644
> --- a/drivers/staging/wfx/fwio.c
> +++ b/drivers/staging/wfx/fwio.c
> @@ -80,7 +80,8 @@ static const char * const fwio_error_strings[] = {
> * NOTE: it may also be possible to use 'pages' from struct firmware and avoid
> * bounce buffer
> */
> -int sram_write_dma_safe(struct wfx_dev *wdev, u32 addr, const u8 *buf, size_t len)
> +static int sram_write_dma_safe(struct wfx_dev *wdev, u32 addr, const u8 *buf,
> + size_t len)
> {
> int ret;
> const u8 *tmp;
> @@ -226,7 +227,7 @@ static void print_boot_status(struct wfx_dev *wdev)
> }
> }
>
> -int load_firmware_secure(struct wfx_dev *wdev)
> +static int load_firmware_secure(struct wfx_dev *wdev)
> {
> const struct firmware *fw = NULL;
> int header_size;
> --
> 2.7.4
>
Reviewed-by: Jérôme Pouiller <jerome.pouiller at silabs.com>
--
Jérôme Pouiller
More information about the devel
mailing list