[Outreachy kernel] [PATCH] staging: rtl8712: Add comment to lock declaration

[Jules Irenge]

On Mon, 7 Oct 2019, Julia Lawall wrote:

>
>
> On Mon, 7 Oct 2019, Jules Irenge wrote:
>
>> Add comment to spinlock declaration to fix warning issued by checkpatch.pl
>> "CHECK: spinlock_t definition without comment".
>
> Since it is not apparent from the shown code, it would be helpful to
> describe what evidence you used to choose this comment.
>
> thanks,
> julia
>

Thanks for your feedback, I will leave as it is following the advice of 
one of the maintainer. I thought a general term of protecting interrupt 
might be appropriate.

Kind regards
Jules


>> Signed-off-by: Jules Irenge <jbi.octave at gmail.com>
>> ---
>>  drivers/staging/rtl8712/drv_types.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h
>> index 0c4325073c63..960d8709aada 100644
>> --- a/drivers/staging/rtl8712/drv_types.h
>> +++ b/drivers/staging/rtl8712/drv_types.h
>> @@ -160,7 +160,7 @@ struct _adapter {
>>  	int pid; /*process id from UI*/
>>  	struct work_struct wk_filter_rx_ff0;
>>  	u8 blnEnableRxFF0Filter;
>> -	spinlock_t lock_rx_ff0_filter;
>> +	spinlock_t lock_rx_ff0_filter; /*spinlock to protect interrupt request*/
>>  	const struct firmware *fw;
>>  	struct usb_interface *pusb_intf;
>>  	struct mutex mutex_start;
>> --
>> 2.21.0
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe at googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191007205248.24466-1-jbi.octave%40gmail.com.
>>
>
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe at googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.1910072254290.2578%40hadrien.
>