[PATCH v3] staging: vc04_services: Avoid NULL comparison

Dan Carpenter dan.carpenter at oracle.com
Wed Oct 9 07:49:16 UTC 2019


On Tue, Oct 08, 2019 at 07:44:15PM -0700, Nachammai Karuppiah wrote:
> Remove NULL comparison. Issue found using checkpatch.pl
> 
> Signed-off-by: Nachammai Karuppiah <nachukannan at gmail.com>
> 
> ---
> 
> Changes in V2
>    - Remove all NULL comparisons in vc04_services/interface directory.
> ---
> 
> changes in V3
>    - Fixed warnings. Reported-by: kbuild test robot <lkp at intel.com>
> ---
> 
> Signed-off-by: Nachammai Karuppiah <nachukannan at gmail.com>
> ---
>  .../interface/vchiq_arm/vchiq_2835_arm.c           |  4 ++--


Only one --- cut off line is needed.  You have two Signed-of-by lines
as well.  It should just be:

Remove NULL comparison. Issue found using checkpatch.pl

Signed-off-by: Nachammai Karuppiah <nachukannan at gmail.com>
---
Changes in V2
   - Remove all NULL comparisons in vc04_services/interface directory.
changes in V3
   - Fixed warnings. Reported-by: kbuild test robot <lkp at intel.com>

  .../interface/vchiq_arm/vchiq_2835_arm.c           |  4 ++--

But this doesn't affect the final patch, and we can see all the
information so it's fine.  No need to resend.

Reviewed-by: Dan Carpenter <dan.carpenter at oracle.com>

regards,
dan carpenter



More information about the devel mailing list