[PATCH] staging: fieldbus: make use of devm_platform_ioremap_resource
hariprasad at osuosl.org
hariprasad at osuosl.org
Tue Oct 8 06:10:56 UTC 2019
From: Hariprasad Kelam <hariprasad.kelam at gmail.com>
fix below issues reported by coccicheck
drivers/staging//fieldbus/anybuss/arcx-anybus.c:135:1-5: WARNING: Use
devm_platform_ioremap_resource for base
drivers/staging//fieldbus/anybuss/arcx-anybus.c:248:1-14: WARNING: Use
devm_platform_ioremap_resource for cd -> cpld_base
Signed-off-by: Hariprasad Kelam <hariprasad.kelam at gmail.com>
---
drivers/staging/fieldbus/anybuss/arcx-anybus.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/fieldbus/anybuss/arcx-anybus.c b/drivers/staging/fieldbus/anybuss/arcx-anybus.c
index 2ecffa4..5b8d0ba 100644
--- a/drivers/staging/fieldbus/anybuss/arcx-anybus.c
+++ b/drivers/staging/fieldbus/anybuss/arcx-anybus.c
@@ -127,12 +127,10 @@ static const struct regmap_config arcx_regmap_cfg = {
static struct regmap *create_parallel_regmap(struct platform_device *pdev,
int idx)
{
- struct resource *res;
void __iomem *base;
struct device *dev = &pdev->dev;
- res = platform_get_resource(pdev, IORESOURCE_MEM, idx + 1);
- base = devm_ioremap_resource(dev, res);
+ base = devm_platform_ioremap_resource(pdev, idx + 1);
if (IS_ERR(base))
return ERR_CAST(base);
return devm_regmap_init_mmio(dev, base, &arcx_regmap_cfg);
@@ -230,7 +228,6 @@ static int controller_probe(struct platform_device *pdev)
struct regulator_config config = { };
struct regulator_dev *regulator;
int err, id;
- struct resource *res;
struct anybuss_host *host;
u8 status1, cap;
@@ -244,8 +241,7 @@ static int controller_probe(struct platform_device *pdev)
return PTR_ERR(cd->reset_gpiod);
/* CPLD control memory, sits at index 0 */
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- cd->cpld_base = devm_ioremap_resource(dev, res);
+ cd->cpld_base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(cd->cpld_base)) {
dev_err(dev,
"failed to map cpld base address\n");
--
2.7.4
More information about the devel
mailing list