[PATCH] staging: wlan-ng: p80211wep.c: use lib/crc32

Thomas Meyer thomas at m3y3r.de
Mon Oct 7 16:15:23 UTC 2019


Dan Carpenter <dan.carpenter at oracle.com> writes:

> On Sun, Oct 06, 2019 at 04:07:45PM +0200, Thomas Meyer wrote:
>> Use lib/crc32 instead of another implementation.
>> 
>> Signed-off-by: Thomas Meyer <thomas at m3y3r.de>
>
> I always get annoyed whenever anyone asks if people have tested their
> patches, but have you tested this?

no annoynence on my side, but... :-)

Good question. I tell you what I did and then you tell me if I did test!

So I did this: I did write a small C program that does contain a small
byte buffer and the extracted CRC32 logic from the wlan driver.
The program does calculate the CRC32 sum with the extracted logic and by
calling crc32_le function. but values are the same.

But as I don't own the hardware I couldn't do a real test with WEP (as
far as I understand only WEP on this hardware would be affected.)

So a better test would be to find someone which actually owns the
hardware and could test the change.

so... what do you think?

with kind regards
thomas

>It's hard for me to review it
> because I don't have the relevant background and because I'm a little
> bit stupid.
>
> regards,
> dan carpenter


More information about the devel mailing list