[PATCH 3/3] Staging: exfat: exfat_super.c Fixed coding style issues.

Dan Carpenter dan.carpenter at oracle.com
Tue Oct 1 13:17:17 UTC 2019


On Sat, Sep 28, 2019 at 07:21:19PM -0500, Jesse Barton wrote:
> Fixed Coding Style issues

Which ones?

> 
> Signed-off-by: Jesse Barton <jessebarton95 at gmail.com>
> ---
>  drivers/staging/exfat/exfat_super.c | 29 +++++++++--------------------
>  1 file changed, 9 insertions(+), 20 deletions(-)
> 
> diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
> index 3c7e2b7c2195..b9656ec06144 100644
> --- a/drivers/staging/exfat/exfat_super.c
> +++ b/drivers/staging/exfat/exfat_super.c
> @@ -640,8 +640,7 @@ static int ffs_lookup_file(struct inode *inode, char *path, struct file_id_t *fi
>  	return ret;
>  }
>  
> -static int ffs_create_file(struct inode *inode, char *path, u8 mode,
> -			 struct file_id_t *fid)
> +static int ffs_create_file(struct inode *inode, char *path, u8 mode, struct file_id_t *fid)

I think now checkpatch will complain that the line is too long?  What we
want here is:

static int ffs_create_file(struct inode *inode, char *path, u8 mode,
			   struct file_id_t *fid)

[tab][tab][tab][space][space][space]struct file_id_t *fid)

So they line up.

regards,
dan carpenter



More information about the devel mailing list