staging: most: configfs: PAGE_SIZE char arrays?

Christian.Gromm at microchip.com Christian.Gromm at microchip.com
Wed Nov 27 10:33:00 UTC 2019


On Di, 2019-11-26 at 11:30 -0800, Joe Perches wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> drivers/staging/most/configfs.c:struct mdev_link {
> drivers/staging/most/configfs.c-        struct config_item item;
> drivers/staging/most/configfs.c-        struct list_head list;
> drivers/staging/most/configfs.c-        bool create_link;
> drivers/staging/most/configfs.c-        bool destroy_link;
> drivers/staging/most/configfs.c-        u16 num_buffers;
> drivers/staging/most/configfs.c-        u16 buffer_size;
> drivers/staging/most/configfs.c-        u16 subbuffer_size;
> drivers/staging/most/configfs.c-        u16 packets_per_xact;
> drivers/staging/most/configfs.c-        u16 dbr_size;
> drivers/staging/most/configfs.c-        char datatype[PAGE_SIZE];
> drivers/staging/most/configfs.c-        char direction[PAGE_SIZE];
> drivers/staging/most/configfs.c-        char name[PAGE_SIZE];
> drivers/staging/most/configfs.c-        char device[PAGE_SIZE];
> drivers/staging/most/configfs.c-        char channel[PAGE_SIZE];
> drivers/staging/most/configfs.c-        char comp[PAGE_SIZE];
> drivers/staging/most/configfs.c-        char comp_params[PAGE_SIZE];
> drivers/staging/most/configfs.c-};
> 
> Why are all the char arrays size PAGE_SIZE ?
> That seems completely unnecessary.

Right. Probably a bad habit when handling userspace.

thanks,
Chris


More information about the devel mailing list