[PATCH] staging: exfat: convert WARN to a pr_info

Valdis Kletnieks valdis.kletnieks at vt.edu
Wed Nov 13 02:50:34 UTC 2019


syzbot took a nosedive because it runs with panic_on_warn set. And
it's quite correct, it shouldn't have been a WARN in the first place.
Other locations just use a pr_info(), so do that here too.

Signed-off-by: Valdis Kletnieks <valdis.kletnieks at vt.edu>
Reported-by: syzbot+787bcbef9b5fec61944b at syzkaller.appspotmail.com
Fixes: c48c9f7ff32b ("staging: exfat: add exfat filesystem code to staging")
---
 drivers/staging/exfat/exfat_blkdev.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/exfat/exfat_blkdev.c b/drivers/staging/exfat/exfat_blkdev.c
index 7bcd98b13109..8204720b2bf2 100644
--- a/drivers/staging/exfat/exfat_blkdev.c
+++ b/drivers/staging/exfat/exfat_blkdev.c
@@ -59,8 +59,8 @@ int exfat_bdev_read(struct super_block *sb, sector_t secno, struct buffer_head *
 	if (*bh)
 		return 0;
 
-	WARN(!p_fs->dev_ejected,
-	     "[EXFAT] No bh, device seems wrong or to be ejected.\n");
+	if (p_fs->dev_ejected)
+		pr_info("[EXFAT] No bh, device seems wrong or to be ejected.\n");
 
 	return -EIO;
 }
@@ -112,8 +112,8 @@ int exfat_bdev_write(struct super_block *sb, sector_t secno, struct buffer_head
 	return 0;
 
 no_bh:
-	WARN(!p_fs->dev_ejected,
-	     "[EXFAT] No bh, device seems wrong or to be ejected.\n");
+	if (p_fs->dev_ejected)
+		pr_info("[EXFAT] No bh, device seems wrong or to be ejected.\n");
 
 	return -EIO;
 }
-- 
2.24.0



More information about the devel mailing list