[PATCH 1/2] staging: vchiq: Move retrieval of rpi_firmware to vchiq_platform_init()

[Greg KH]

On Mon, Nov 11, 2019 at 12:14:23PM -0500, Marcelo Diop-Gonzalez wrote:
> This allows the removal of the struct rpi_firmware* member
> from struct vchiq_drvdata.
> 
> Signed-off-by: Marcelo Diop-Gonzalez <marcgonzalez at google.com>
> ---
>  .../interface/vchiq_arm/vchiq_2835_arm.c           | 14 +++++++++++++-
>  .../vc04_services/interface/vchiq_arm/vchiq_arm.c  | 14 --------------
>  .../vc04_services/interface/vchiq_arm/vchiq_arm.h  |  1 -
>  3 files changed, 13 insertions(+), 16 deletions(-)

This commit breaks the build:

In function ‘free_pagelist’,
    inlined from ‘vchiq_complete_bulk’ at drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c:258:3:
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c:588:4: warning: argument 2 null where non-null expected [-Wnonnull]
  588 |    memcpy((char *)kmap(pages[0]) +
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  589 |     pagelist->offset,
      |     ~~~~~~~~~~~~~~~~~
  590 |     fragments,
      |     ~~~~~~~~~~
  591 |     head_bytes);
      |     ~~~~~~~~~~~

Please be more careful and at least test your changes before sending
them out :(

greg k-h