staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function

[Greg Ungerer]

Hi Sergio,

On 29/5/19 6:08 pm, Sergio Paracuellos wrote:
[snip]
> I have added gpio consumer stuff and reorder a bit the code to be more
> similar to 4.20.
> 
> I attach the patch. I have not try it to compile it, because my normal
> environment is in another
> computer and I am in the middle of moving from my current house and
> don't have access to it, sorry.
> So, please try this and let's see what happens.

No problem, thanks for the patch.

Unfortunately always locks up on kernel boot:

   ...
   mt7621-pci-phy 1e149000.pcie-phy: Xtal is 40MHz
   mt7621-pci 1e140000.pcie: Port 454043648 N_FTS = 0
   mt7621-pci-phy 1e149000.pcie-phy: Xtal is 40MHz
   mt7621-pci 1e140000.pcie: Port 454043648 N_FTS = 1
   mt7621-pci-phy 1e14a000.pcie-phy: Xtal is 40MHz
   mt7621-pci 1e140000.pcie: Port 454043648 N_FTS = 2
   mt7621-pci 1e140000.pcie: pcie0 no card, disable it (RST & CLK)
   mt7621-pci 1e140000.pcie: pcie1 no card, disable it (RST & CLK)
   mt7621-pci 1e140000.pcie: pcie2 no card, disable it (RST & CLK)

That was original linux-5.1 patched with your attached patch.

I'll try and dig down into that further today and get some
feedback on where it is failing.

Regards
Greg